Include Bazel version information in profile metadata. #17562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is helpful when building tools on top of the JSON profile which might to need to distinguish with what Bazel version the profile was written to be able to parse or interpret it correctly.
|
cc @saraadams |
Thank you! |
sgowroji
added
team-Performance
|
@meisterT Nice! This isn't a breaking change, right? Can it go into 6.1? |
|
If we do other cherry picks anyway, this should be easy to add. |
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 6.1.0 |
bazel-io
removed
the
potential release blocker
keertk
removed
the
awaiting-review
keertk
pushed a commit
that referenced
this pull request
Feb 28, 2023
This is basically the same as https://github.com/bazelbuild/bazel/pull/17562/files before we did the JSON trace profile refactoring. --- This is helpful when building tools on top of the JSON profile which might to need to distinguish with what Bazel version the profile was written to be able to parse or interpret it correctly. Closes #17562. PiperOrigin-RevId: 511761823 Change-Id: I9c31494bfc07be898250d75821dd080e5b68b6db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is helpful when building tools on top of the JSON profile which might to need to distinguish with what Bazel version the profile was written to be able to parse or interpret it correctly.